search

mdqinc / SDL_GameControllerDB

A community sourced database of game controller mappings to be used with SDL2 Game Controller functionality
http://libsdl.org
zlib License
1.38k stars 520 forks source link

Adding iCode Retro USB adapters #732

Closed alijani1 closed 10 months ago

alijani1 commented 10 months ago

I am the creator of the popular iCode Retro USB Adapters that let you use classic controllers like Atari, Colecovision, Sega controllers with your emulators. [https://www.icode.com/product-category/gaming/gaming-adapters/](see icode.com)

I added the iCode adapter configurations to support many platforms like the c64mini/maxi. please merge. thank you!

offalynne commented 10 months ago

Great, thank you ! Unfortunately it looks like you've copied the mappings across platforms from Linux without actually authoring and testing on those platforms. Each platform is different, and you should not assume GUID will match, nor buttons or axes enumerate the same. Please revise your PR with mappings authored and tested per platform, or remove mappings for any platforms you are personally unable to cover.

Thanks again !

offalynne commented 10 months ago

I have corrected the Windows GUID format and removed invalid Mac and Android mappings. Feel free to open a PR in the future if you want to contribute support for those platforms and are able to author and test them as required.

alijani1 commented 10 months ago

I have corrected the Windows GUID format and removed invalid Mac and Android mappings. Feel free to open a PR in the future if you want to contribute support for those platforms and are able to author and test them as required.

Thank you. The main one we needed was Linux.