search

mdqinc / SDL_GameControllerDB

A community sourced database of game controller mappings to be used with SDL2 Game Controller functionality
http://libsdl.org
zlib License
1.33k stars 505 forks source link

Add mappings for `1105` and `1405` Xbox Series X Controllers on Linux #751

Closed akien-mga closed 4 months ago

akien-mga commented 4 months ago

This is for a first-party Xbox Series X Controller plugged with USB. There are already mappings for the bluetooth UID it seems.

Draft for now as I believe this controller (at least with the current firmware) needs a mapping for macOS too (wireless mode). I'll test on Windows tomorrow to see if it needs a dedicated mapping too.

Mapping generated with SDL2's controllermap.

akien-mga commented 4 months ago

I tested on Windows and the same controller works fine in both USB and wireless modes.

I do believe there are issues with macOS wireless mappings for that GUID, at least my team mates had that issue in Godot during a weekend jam. I don't have direct access to a Mac now to test myself, I'll see if I can find one to borrow for a quick test.

akien-mga commented 4 months ago

So I updated the firmware for one of my Xbox controllers, and it got a new GUID again, which requires the same mapping.

With my commit there's now 3 times the same mapping for USB Xbox Series X controllers on Linux, with slightly different GUIDs (only the last byte is changing).

Should SDL-like gamepad implementations simply ignore that last byte and use whichever mapping matches the 030000005e040000120b0000 part? If so this might be something we need to fix in Godot more than here.

Xbox controller firmware updates seem frequent so keep track of all of them seems a bit tricky.

Edit: From looking through the list of Linux mappings, I see quite a few where only the last byte is different, and where the mapping is either the same, or actually changed. So I guess we need to just grab new mappings every time there's a firmware update? :\

offalynne commented 4 months ago

Interesting questions but not relevant here. If the device works as-is in controllermap, no mapping is necessary. If not, a mapping is necessary. Changes to ignore particular components of the GUID to normalize support on the end of SDL (or Godot, or whatever) are worth pursuing upstream in those projects; the db is just data. Regardless, we accept mappings if the GUID-mapping pair is unique as it will improve support for the device with the plethora of existing software that already support ingest of the db.

offalynne commented 4 months ago

Merging, feel free to open another PR with Mac mappings