search

mds1 / evm-diff

Diff EVM-compatible chains in a friendly format
https://evmdiff.com
MIT License
278 stars 27 forks source link

feat: add `types` module #13

Closed leovct closed 1 year ago

leovct commented 1 year ago

Description

Note: this PR should be merged after #12

To keep the repository simple and well organised, I moved the types defined in src/chains/types.ts to their own module src/types. In this folder, each type has its own file, e.g. src/types/opcode.ts.

$ tree src/types
src/types
├── chain.ts
├── opcode.ts
└── precompiles.ts

1 directory, 3 files

Test

$ pnpm fmt:check
> evm-diff@0.1.0 fmt:check /Users/leovct/Documents/opensource/evm-diff
> prettier --check .

Checking formatting...
All matched files use Prettier code style!

$ pnpm build
> evm-diff@0.1.0 build /Users/leovct/Documents/opensource/evm-diff
> next build

info  - Linting and checking validity of types  
info  - Creating an optimized production build  
info  - Compiled successfully
info  - Collecting page data  
info  - Generating static pages (4/4)
info  - Finalizing page optimization  

Route (pages)                              Size     First Load JS
┌ ○ /                                      558 B          99.7 kB
├   /_app                                  0 B            83.3 kB
├ ○ /404                                   182 B          83.4 kB
└ ○ /diff                                  21.1 kB         120 kB
+ First Load JS shared by all              88.1 kB
  ├ chunks/framework-cda45640750da278.js   45.2 kB
  ├ chunks/main-1e0620acb78b93fb.js        26.8 kB
  ├ chunks/pages/_app-47443414f282c22a.js  9.57 kB
  ├ chunks/webpack-52a83b85e685af40.js     1.61 kB
  └ css/a7410964315e4c62.css               4.88 kB

○  (Static)  automatically rendered as static HTML (uses no initial props)
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2023 1:04am
mds1 commented 1 year ago

@leovct Looks like this PR and #14 have the old commits from #12 as well as conflicts. I think the easiest approach might just be to close both PRs and then just copy over the code changes for this one into a new PR. I think even if you cherry pick commit e103a3b there will be a lot of conflicts. Sorry about that! 😬

leovct commented 1 year ago

Closing this PR and opening a new one #18