search

mds1 / evm-diff

Diff EVM-compatible chains in a friendly format
https://evmdiff.com
MIT License
272 stars 27 forks source link

add rpc urls #76

Closed Cahl-Dee closed 1 month ago

Cahl-Dee commented 1 month ago

Adding RPC URLs for QuickNode to the list for the chains that we support.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 7:35pm
mds1 commented 1 month ago

Can you provide context on the purpose of this PR? The contents in the data/ folder are autogenerated, so these changes will get overwritten next time data is updated

Cahl-Dee commented 1 month ago

Ah thanks for the feedback Matt.

Just adding the RPC URLs for QuickNode to the list.

Happy to make the change in the appropriate way so that it doesn't get overwritten. Also looks like the dotenv example isnt getting generated with the placeholders to fill in for providers other than Infura.

Cahl-Dee commented 1 month ago

I see, you're pulling from Chainlist here https://github.com/mds1/evm-diff/blob/44f936571d56427cfe65c8beaad43aa60a59d221/script/index.ts#L84C32-L84C67

I'll submit our endpoints there.

Thanks again, Matt.

mds1 commented 1 month ago

Yes exactly, thank you! And those RPC URLs are used in two places:

  1. In the UI to show a list of RPC URLs.
  2. In the scripts to fetch data.

That second once is where script/.env.example comes into play. We can add a new QUICKNODE_API_KEY to that file, and it would get populated here when fetching chain data