mds1 / evm-diff

Diff EVM-compatible chains in a friendly format
https://evmdiff.com
MIT License
272 stars 27 forks source link

add routescan explorers #78

Open IperGiove opened 3 weeks ago

IperGiove commented 3 weeks ago

This PR is promoted by Routescan with the aim of improving the quality of the data as much as possible in an open-source manner.

The PR just adds the links to Routescan's explorer in the json chains data.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 9:46pm
mds1 commented 3 weeks ago

The modified files are autogenerated, so this will be overwritten the next time data is updated.

Instead, we’ll want to modify script/data/input.json to add these additional explorers as inputs, and modify the getMetadata method to include them in the output data

IperGiove commented 3 weeks ago

The modified files are autogenerated, so this will be overwritten the next time data is updated.

Instead, we’ll want to modify script/data/input.json to add these additional explorers as inputs, and modify the getMetadata method to include them in the output data

I know you are using this repo for the api here`:

async function getMetadata(chainId: number): Promise<Metadata> {
    const response = await fetch('https://chainid.network/chains.json');
    const data = await response.json();
    const metadata = data.find((chain: Metadata) => chain.chainId === chainId);
    if (!metadata) throw new Error(`Chain with ID ${chainId} not found.`);
    return metadata;
}

And that repo gets the data from this one. For that reason yesterday I made a PR to update the data here: https://github.com/ethereum-lists/chains/pull/5428.

However, do you mean you want to transform the script/data/feature/metadata.json into something like script/data/input.json? is that correct?

mds1 commented 3 weeks ago

Ah that’s perfect, adding it upstream is preferable. Let’s give the https://github.com/ethereum-lists/chains repo some time to merge that, in which case we can close this and have it included automatically