mdsb100 / cli-gitlab

GitLab CLI library
101 stars 11 forks source link

Unable to list notes for a merge request #12

Closed Tzrlk closed 7 years ago

Tzrlk commented 7 years ago

According to the gitlab api docs for Notes, I should be able to list all the comments for a merge request by running a GET to /projects/:id/merge_requests/:merge_request_iid/notes. Unfortunately, when I try to run gitlab issueNotes :id :merge_request_id I get the following:

sh-4.4$ gitlab issueNotes [redacted] [redacted]
C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\bin\worker.js:267
      return target[fn].apply(target, arg);
                   ^

TypeError: Cannot read property 'all' of undefined
    at Command.<anonymous> (C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\bin\worker.js:267:20)
    at Command.listener (C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\node_modules\commander\index.js:301:8)
    at emitTwo (events.js:106:13)
    at Command.emit (events.js:194:7)
    at Command.parseArgs (C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\node_modules\commander\index.js:615:12)
    at Command.parse (C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\node_modules\commander\index.js:458:21)
    at Object.<anonymous> (C:\Users\[redacted]\AppData\Roaming\npm\node_modules\cli-gitlab\bin\command.js:19:9)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
mdsb100 commented 7 years ago

@Tzrlk what`s version of node-gitlab?

mdsb100 commented 7 years ago

Unfortunately gitlab issueNotes ==> GET /projects/:id/issues/:issue_iid/notes '/projects/:id/merge_requests/:merge_request_iid/notes' not support in node-gitlab now

mdsb100 commented 7 years ago

Fix gitlab issueNotes not work