search

mdshack / shotshare

Open source image sharing application
https://demo.shotshare.dev/
MIT License
137 stars 10 forks source link

Deleted images is still be accessable via direct link #41

Closed ai-ri-kr closed 9 months ago

ai-ri-kr commented 9 months ago

A deleted image should be like that, deleted. The image should not still be stored on the server after deletion. Please fix.

Also, please add a command that allows you to clear deleted images only.

EmberHeartshine commented 9 months ago

Can confirm, just tested. Not sure if there's a cleanup task or what but the images are still on the disk and accessible by direct link. Deleting the image file obviously fixes it.

mdshack commented 9 months ago

Thanks for raising this issue, I popped a fix for this here. We will see this go out in the next release (1.9.0), and I will update here when that is rolling out.

ai-ri-kr commented 9 months ago

Very nice! What I saw, 1.9.0 will only add deletion of the file and not add a new command (shotshare:clean-deleted-images), correct?

mdshack commented 9 months ago

Very nice! What I saw, 1.9.0 will only add deletion of the file and not add a new command (shotshare:clean-deleted-images), correct?

Since this was a bug I am not sure adding a command to handle a condition that shouldn't be in the future is the correct move, I might do a migration to handle this but there might be a better way to handle this, lemme think on it for a bit.

mdshack commented 9 months ago

Very nice! What I saw, 1.9.0 will only add deletion of the file and not add a new command (shotshare:clean-deleted-images), correct?

I ended up adding an --only-missing flag to the existing clean images command.

mdshack commented 9 months ago

This functionality has just been rolled out with the latest release 1.9.1!