Variant fasta non ref chr

mdshw5 / pyfaidx

Efficient pythonic random access to fasta subsequences

https://pypi.python.org/pypi/pyfaidx

Other

459 stars 75 forks source link

Variant fasta non ref chr #180

Closed lldelisle closed 3 years ago

lldelisle commented 3 years ago

To solve #179 I added a test to show in which cases it fails. I added some try catch to solve this issue. I think the expected behaviour is that it returns the sequence from the fasta without any modification.

lldelisle commented 3 years ago

I am stuck because I don't know why tests/data/download_gene_fasta.py is failing on travis. I force added the data to check it worked.

mdshw5 commented 3 years ago

Thanks for the contribution. I'll take a look when I have a minute and see what's going wrong.

mdshw5 commented 3 years ago

@lldelisle it looks like Travis-CI is not providing build credits for this project anymore, so I will transition to GH Actions (#181).

mdshw5 commented 3 years ago

This looks good @lldelisle. Thanks for contributing this change. I'll merge now and tag a new release (0.6.3) which should show up on PyPI in a few minutes.

lldelisle commented 3 years ago

Thank you.