mdshw5 / pyfaidx

Efficient pythonic random access to fasta subsequences
https://pypi.python.org/pypi/pyfaidx
Other
459 stars 75 forks source link

Implement fsspec handling for indexname #193

Closed ap-- closed 2 years ago

ap-- commented 2 years ago

Hi @mdshw5

I took #192 and made some minor changes to make it work. This PR also adds 3 more indexname tests and an example to the README.

Cheers, Andreas 😃

mdshw5 commented 2 years ago

I like your definition of minor changes 😃. Seriously though, this is great work and I can't thank you enough. Thanks to the added tests and the clarity of your implementation this is a no-brainer to merge and release!