search

mdshw5 / pyfaidx

Efficient pythonic random access to fasta subsequences
https://pypi.python.org/pypi/pyfaidx
Other
459 stars 75 forks source link

missing setuptools dependency in 0.7.2 #206

Closed ryanking closed 1 year ago

ryanking commented 1 year ago

When trying to upgrade from 0.7.1 to 0.7.2, I started getting errors from pyfaidx like:

../../named_caches/pex_root/venvs/s/ca27a750/venv/lib/python3.8/site-packages/pyfaidx/__init__.py:21: in <module>
    from pkg_resources import get_distribution
E   ModuleNotFoundError: No module named 'pkg_resources'

It seems that in the switch to pyproject.toml, the dependency on setuptools got droped.

mdshw5 commented 1 year ago

@ryanking Thanks for reporting this, and I'm sorry you had this issue. I clearly overlooked the version string mechanism I was using (and didn't have any tests for!) when I switched to pyproject.toml. I've created a new release (v0.7.2.1) which is currently making its way though CI/CD. I should be installable from PyPI in the next 15 minutes now. Can you test this version and make sure it fixes the issue for you?

ryanking commented 1 year ago

@mdshw5 updated and working locally, testing in CI should work too.

Thanks for the quick response!