mdshw5 / pyfaidx

Efficient pythonic random access to fasta subsequences
https://pypi.python.org/pypi/pyfaidx
Other
449 stars 75 forks source link

Update documentation for get_seq which uses 1-based closed intervals #222

Closed eroller closed 1 month ago

codecov[bot] commented 1 month ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

mdshw5 commented 1 month ago

Good catch! After reviewing my test data (https://github.com/mdshw5/pyfaidx/blob/1075c8ea8212df065fbb012cc89f9a8fead05c33/tests/test_feature_bounds_check.py#L67-L79) I agree that the fetch method uses 1-based indices and is end-inclusive.