mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps
MIT License
53 stars 20 forks source link

[MCC-186539] added try catch and logging in background thread action #62

Closed bvillanueva-mdsol closed 9 years ago

bvillanueva-mdsol commented 9 years ago

@kenyamat @lschreck-mdsol @BPONTES @jcarres-mdsol

This PR is about adding robustness in zipkin client. On a background thread, this implementation will add a try catch block and logs any exception occurred. This will prevent any consumer of zipkin client to potentially crash because of unhandled exception in background threads.

Please review and merge if ok. Thank you.

lschreck-mdsol commented 9 years ago

Looks good to me, the unit tests are passing as well. Although this time I would leave the merging to other members (still on training).

bvillanueva-mdsol commented 9 years ago

@kenyamat @lschreck-mdsol @BPONTES @jcarres-mdsol

As per discussion and recommendation by @kenyamat yesterday, we made this following updates 535a61b

Works very fine with Validation Zipkin server (old version). I have a good feeling it would work fine with the new server too :pray: :pray: :pray:

Please review. Thanks

bvillanueva-mdsol commented 9 years ago

@lschreck-mdsol Thanks for the review :+1:

bvillanueva-mdsol commented 9 years ago

@kenyamat Thanks for looking into that. Combined the two constructors here --> b864e44

bvillanueva-mdsol commented 9 years ago

@kenyamat Pushed changes for recommendation on 30seconds delay here --> c680bcf Thanks! Tested locally on new server, tried 20 times logging without errors.

Please merge if implementation is ok.

kenyamat commented 9 years ago

LGTM. Could you bump up version for nuget?

bvillanueva-mdsol commented 9 years ago

@kenyamat Thanks! Bumped version here --> e78ddaf

kenyamat commented 9 years ago

LGTM