Closed bvillanueva-mdsol closed 9 years ago
Looks good to me, the unit tests are passing as well. Although this time I would leave the merging to other members (still on training).
@kenyamat @lschreck-mdsol @BPONTES @jcarres-mdsol
As per discussion and recommendation by @kenyamat yesterday, we made this following updates 535a61b
Works very fine with Validation Zipkin server (old version). I have a good feeling it would work fine with the new server too :pray: :pray: :pray:
Please review. Thanks
@lschreck-mdsol Thanks for the review :+1:
@kenyamat Thanks for looking into that. Combined the two constructors here --> b864e44
@kenyamat Pushed changes for recommendation on 30seconds delay here --> c680bcf Thanks! Tested locally on new server, tried 20 times logging without errors.
Please merge if implementation is ok.
LGTM. Could you bump up version for nuget?
@kenyamat Thanks! Bumped version here --> e78ddaf
LGTM
@kenyamat @lschreck-mdsol @BPONTES @jcarres-mdsol
This PR is about adding robustness in zipkin client. On a background thread, this implementation will add a try catch block and logs any exception occurred. This will prevent any consumer of zipkin client to potentially crash because of unhandled exception in background threads.
Please review and merge if ok. Thank you.