[MCC-186539] Refactor - Githubissues

mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps

MIT License

53 stars 20 forks source link

Closed bvillanueva-mdsol closed 9 years ago

bvillanueva-mdsol commented 9 years ago

@kenyamat @jcarres-mdsol @BPONTES @lschreck-mdsol

This PR corrects the span name information resulting to some interface change on zipkin client.

Span name has now has a format of --> "{Context Method Name} {Context Absolute path}"
Start Trace returns a span which should be used on later when doing stop trace passing the same span instance.

Please review if change is ok and merge.

Thanks, Brent

bvillanueva-mdsol commented 9 years ago

@kenyamat @lschreck-mdsol Latest update 9fe864d is tested ok locally, please review if changes are ok then please merge. Thank you.

lschreck-mdsol commented 9 years ago

@bvillanueva-mdsol Very good, thanks! :+1: