Switch Zipkin HttpModule to use HTTP requests instead of Thrift.

mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps

MIT License

53 stars 20 forks source link

Switch Zipkin HttpModule to use HTTP requests instead of Thrift. #67

Closed BPONTES closed 8 years ago

BPONTES commented 8 years ago

@jcarres-mdsol @kenyamat @lschreck-mdsol I have completed Gutted the code so it works with HTTP. This will be a major change since it requires HTTP after this and won't support Thrift. I rather focus on one protocol then have both. Please review the code and let me know if it looks good.

BPONTES commented 8 years ago

I addressed the PR comments and also cleaned up the code a little, once it looks good and is merged I will push out the new packages to Gambit.

kenyamat commented 8 years ago

I tried add-hoc on my local and sandbox. There were no issues. And now we can send zipkin spans on your local machine. Thank you for your great refactoring.