search

mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps
MIT License
53 stars 20 forks source link

[MCC-199419] Add domain config #71

Closed bvillanueva-mdsol closed 8 years ago

bvillanueva-mdsol commented 8 years ago

@kenyamat @lschreck-mdsol @cabbott @BPONTES @jcarres-mdsol

This is in relation to the ruby implementation: https://mdsol.jiveon.com/community/research-development/rd-guilds/architecture-guild/projects/monitoring-and-health/blog/2015/12/08/unifying-caller-and-callee-names-on-zipkin This PR is about adding domain config to be used as service name. if (domain config is not null or empty) use config.Domain else use config.ServiceName Please review

Thanks, Brent

kenyamat commented 8 years ago

LGTM

lschreck-mdsol commented 8 years ago

Looks fine to me, if no objections, I'll merge.

kenyamat commented 8 years ago

@lschreck-mdsol @bvillanueva-mdsol published new version. https://www.nuget.org/packages/Medidata.ZipkinTracer.Core/ https://www.nuget.org/packages/Medidata.ZipkinTracer.HttpModule/