search

mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps
MIT License
53 stars 20 forks source link

[MCC-199419] get host from domain (url string) #75

Closed bvillanueva-mdsol closed 8 years ago

bvillanueva-mdsol commented 8 years ago

@kenyamat @lschreck-mdsol @jcarres-mdsol @cabbott

After doing a local adhoc on domain config on gambit, I realized that config.domain value is a url string. In order for the servicename that will be submitted to zipkin server to be valid, zipkin has to extract the hostname from config.domain string value. If operation is unsuccessful, servicename = config.zipkinServiceName

Please review this change and merge. I'll upload this to nuget server and be used again for local adhoc for Gambit.

Thanks, Brent

lschreck-mdsol commented 8 years ago

Looks as a :+1: to me. If no objections, I will merge!