mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps
MIT License
53 stars 20 forks source link

[MCC-203861] implement middleware and handler #77

Closed kenyamat closed 8 years ago

kenyamat commented 8 years ago

@lschreck-mdsol @bvillanueva-mdsol @mdsol/monitoring-sentinels create middleware and handler for zipkin. Please review.

kenyamat commented 8 years ago

@lschreck-mdsol @bvillanueva-mdsol implement Record methods. Please check 2743eb1.

kenyamat commented 8 years ago

@lschreck-mdsol @bvillanueva-mdsol removed Record methods. It will refactor next feature updates.

lschreck-mdsol commented 8 years ago

@jcarres-mdsol Just for the record, we talked regarding implementing the Record methods and Local Component in the message handler with @kenyamat and we concluded that it is quite cumbersome as the handler assumes an automatic execution (without additional input parameters) while the record methods are there to support the users of the library to push custom information to the span - these two concepts are quite on the contrary. Ultimately if the message handler won't support this it is fair enough IMHO, as we still have the ZipkinClient which can be used in these cases.

kenyamat commented 8 years ago

@bvillanueva-mdsol @lschreck-mdsol refactor ZipkinConfig and ZipkinSampler 6142016

kenyamat commented 8 years ago

@lschreck-mdsol @bvillanueva-mdsol

kenyamat commented 8 years ago

make TraceProvier to internal. afe9fee bump version up to 2.0.0. 180056d

bvillanueva-mdsol commented 8 years ago

LGTM :+1:

kenyamat commented 8 years ago

update README.md 16a4f2b. Please merge if you are OK.

kenyamat commented 8 years ago

@bvillanueva-mdsol thank you for your catch. try to use Domain instead of ServiceName. 5d84aa1

kenyamat commented 8 years ago

@bvillanueva-mdsol fix! 9d8d89c

bvillanueva-mdsol commented 8 years ago

LGTM :+1:

lschreck-mdsol commented 8 years ago

Retrospectively LGTM :clap: :grinning: