Closed kenyamat closed 8 years ago
@lschreck-mdsol @bvillanueva-mdsol implement Record methods. Please check 2743eb1.
@lschreck-mdsol @bvillanueva-mdsol removed Record methods. It will refactor next feature updates.
@jcarres-mdsol Just for the record, we talked regarding implementing the Record methods and Local Component in the message handler with @kenyamat and we concluded that it is quite cumbersome as the handler assumes an automatic execution (without additional input parameters) while the record methods are there to support the users of the library to push custom information to the span - these two concepts are quite on the contrary. Ultimately if the message handler won't support this it is fair enough IMHO, as we still have the ZipkinClient which can be used in these cases.
@bvillanueva-mdsol @lschreck-mdsol refactor ZipkinConfig and ZipkinSampler 6142016
@lschreck-mdsol @bvillanueva-mdsol
make TraceProvier to internal. afe9fee bump version up to 2.0.0. 180056d
LGTM :+1:
update README.md 16a4f2b. Please merge if you are OK.
@bvillanueva-mdsol thank you for your catch. try to use Domain instead of ServiceName. 5d84aa1
@bvillanueva-mdsol fix! 9d8d89c
LGTM :+1:
Retrospectively LGTM :clap: :grinning:
@lschreck-mdsol @bvillanueva-mdsol @mdsol/monitoring-sentinels create middleware and handler for zipkin. Please review.