[MCC-210402] Remove Thrift and refactor the Zipkin Tracer Module - Githubissues

mdsol / Medidata.ZipkinTracerModule

[Deprecated] Zipkin Request Tracing for .Net Apps

MIT License

53 stars 20 forks source link

[MCC-210402] Remove Thrift and refactor the Zipkin Tracer Module #81

Closed lschreck-mdsol closed 8 years ago

lschreck-mdsol commented 8 years ago

This PR incorporates the following refactorings:

Removed the Thrift-specific models/classes, and reimplemented the necessary objects manually
Merged the Core and Collector projects together
Removed the unnecessary dependencies
Reimplemented the serializable classes as Json-serializable classes

The following tests were done:

All unit tests are passed
Did adhoc testing on local machine
Integrated to and executed with Ampridatvir

@kenyamat @bvillanueva-mdsol Please review the PR and merge it, if it's OK!

kenyamat commented 8 years ago

LGTM