search

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

Fix Template generation fails if the target directory is missing #62

Closed cross311 closed 11 years ago

cross311 commented 11 years ago

DefaultTemplateFile now checks for folder location before writing template. BUG #50. Decided to do it in DefaultTemplateFile due to AvailableTemplates.templates_location could be over written with another path, so technically each template file generated could have a different folder location.

Questions:

Should I bump the version?

Notes:

Just trying to brush up on my ruby (it has been a long time) so all criticism is welcome. Thought a good way to brush up would be to help fix some bugs in MDSOL open source projects.

Tests:

22 scenarios (22 passed) 83 steps (83 passed) 0m7.150s

Please review @asmith-mdsol

asmith-mdsol commented 11 years ago

Thanks for picking this up Conner! Aside from handling recursive directory creation, looks great.

Please also add yourself to the list of contributors at the end of the README -- you should get credit for your contribution!

cross311 commented 11 years ago

22 scenarios (22 passed) 82 steps (82 passed) 0m9.208s

asmith-mdsol commented 11 years ago

Great! Thanks for extending the test coverage to include the recursive creation of directories.

asmith-mdsol commented 11 years ago

We'll bump the version at some point later...