search

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

Document that configuration files must not be loaded in Rails config/application.rb #63

Closed cross311 closed 10 years ago

cross311 commented 11 years ago

Adding documentation in response to Bug #22.

Please review @asmith-mdsol

asmith-mdsol commented 11 years ago

Thanks Conner! I'd actually forgot what the issue was here. Could you expand the explanation here a bit? I don't think it's obvious why this might be a gotcha. An example would be running rake config spec if you had some code in config/application.rb dependent on a config file generated by DiceBag this would fail because that file is run before the config task gets run.

cross311 commented 11 years ago

That sounds good. I will create a quick rails app that has the issue, so I can see the exact error message to put in the explanation. I will also expand on what setup causes the issue.

cross311 commented 10 years ago

Updated the wording. I was unable to get the dalton project to build at the point right before merge of the fixing pull request. Due to this I was not able to get the exact error message, but I imagine it would be different for each config that is loaded anyway.

Let me know if this makes less sense then before.

asmith-mdsol commented 10 years ago

Thanks Conner! :thumbsup: