Omit .dice files in Bundler path or in dot-prefixed directories

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.

MIT License

19 stars 4 forks source link

Omit .dice files in Bundler path or in dot-prefixed directories #71

Closed harryw closed 10 years ago

harryw commented 10 years ago

This adds an implicit feature to ignore .dice files that have been installed with vendored gems in a subdirectory.

Cucumber tests are included. Testing was by far the most difficult part of this change. The tests run Bundler to install dice_bag's dependencies in a subdirectory so they are slower than other tests, but still only a few seconds.

I've also added a test to document the existing behaviour with dot-prefixed directories, as described in issue #69.

jcarres-mdsol commented 10 years ago

+1 @asmith-mdsol I think it is good to merge

benton commented 10 years ago

I think so too. Passes all tests on my workstation, and seems to behave correctly when configuring Eureka. Nice work.

asmith-mdsol commented 10 years ago

Thanks for diligent testing here Harry!