search

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

adds support for bang methods which allow for checking on production … #74

Closed jcarres-mdsol closed 9 years ago

jcarres-mdsol commented 9 years ago

…environment

@cabbott @jfeltesse-mdsol @miwest929

In many projects we are checking if we are in produciton and making some kind of adhoc solution to error when variables were not set. This takes that pattern into a gem for great merry and joy of its users.

It's backwards compatible as you can not set variables with ! in the terminal.

jfeltesse-mdsol commented 9 years ago

Code wise it looks ok to me although there are bits I'm not sure I understand (like that features/step_definitions/rails.rb file) but I guess it's me needing to get serious about learning cucumber.

jcarres-mdsol commented 9 years ago

Build failed because can't download ruby. Reason probably is because S3 is down today

HonoreDB commented 9 years ago

Cool, makes sense to me. It'd be nice to make this be less Rails-specific (Sinatra has environments too!) maybe for now just extracting in_production? into its own method?

jcarres-mdsol commented 9 years ago

@HonoreDB Very good suggestion, I hope 84c8908 satisfies it

HonoreDB commented 9 years ago

Cool, thank you! I'll merge at end of day today if nobody objects.

jcarres-mdsol commented 9 years ago

@HonoreDB you forgot to merge :whale: