search

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

Generate templates with an option to preserve existing changes #75

Closed ghost closed 8 years ago

ghost commented 8 years ago

changes to config:generate_all so it allows user the option to review the diff and preserve any project specific customization.

ghost commented 8 years ago

@jcarres-mdsol im thinking maybe its cleaner if I create separate 'force' generate tasks 

config:generate_all:force
config:generate:force[filename, location]

This will get rid of the additional boolean input. any thoughts?

jcarres-mdsol commented 8 years ago

@atierney-mdsol on one hand sounds good, easier to call. On the other hand we already have a bunch of tasks, I think it will be confusing for users to have too many tasks to choose from and pollute the rails tasks. Looking at the tasks file in general what's easier for you as user?

atierney-mdsol commented 8 years ago

@atrivedi-mdsol think I got tagged in by mistake :smile:

ghost commented 8 years ago

@jcarres-mdsol I did a very extensive poll (i.e. asked 2 people at work) about which task seem easier. they seem to prefer config:generate_all:force over config:generate_all[true]. I agree, personally i think the :force variant reads better and is more explicit about what it does. it also removes the extra code we need to put in to verify user input.

jcarres-mdsol commented 8 years ago

@atrivedi-mdsol The poll seems extensive enough to me. Your PR is perfect. Travis seems to have a weird problem though. Maybe is a hiccup, can you do one more commit to make it run tests again? Maybe you can add ruby 2.2 to the travis.yml file. We need that anyways. Also .ruby_version should probably be ruby 2.0 at least.

ghost commented 8 years ago

Thanks @jcarres-mdsol. I updated travis.yml and .ruby-version travis isn't playing nice with ruby 1.9.3 build. any idea what causes this error? (works locally with 1.9.3)

NoMethodError: undefined method `spec' for nil:NilClass
An error occurred while installing dice_bag (1.0.0), and Bundler cannot
continue

Some gem dependency you reckon?

ghost commented 8 years ago

looks like CI failure is caused by bundler/bundler#3559

jcarres-mdsol commented 8 years ago

Probably can be solved by updating to latest bundler version before running the tests. Something like adding this to the .travis.yml

install:

On Wed, Dec 16, 2015 at 9:48 PM, Abhi Trivedi notifications@github.com wrote:

looks like CI failure is caused by bundler/bundler#3559 https://github.com/bundler/bundler/pull/3559

— Reply to this email directly or view it on GitHub https://github.com/mdsol/dice_bag/pull/75#issuecomment-165234319.

Jordi Polo Carres | Software Architect | Medidata Solutions Worldwide http://www.mdsol.com/

jcarres-mdsol commented 8 years ago

Oh, it seems it passed. I'm having problems with Travis and bundler this couple of days, maybe they solved them. Merging! :tada: