search

mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

Automatically push tagged commits to rubygems #83

Closed jcarres-mdsol closed 6 years ago

jcarres-mdsol commented 6 years ago

@mdsol/team-10

piao-mdsol commented 6 years ago

Ping @mdsol/team-10 🙇

ykitamura-mdsol commented 6 years ago

I think we should add the condition option: https://github.com/openzipkin/zipkin-ruby/pull/120

piao-mdsol commented 6 years ago

@ykitamura-mdsol Took the liberty of adding it fba3682 🙏

Travis CI doc: https://docs.travis-ci.com/user/deployment#conditional-releases-with-on

ykitamura-mdsol commented 6 years ago

I prefer to have https://github.com/mdsol/dice_bag/pull/83/commits/8917c4befe56cae1d2a6198acc1546144a88345e changes in https://github.com/mdsol/dice_bag/pull/84

piao-mdsol commented 6 years ago

@ykitamura-mdsol oops sorry that commit was not intentional.. reverted in 4137db8 🙇

jfeltesse-mdsol commented 6 years ago

we're going to remove this branch once it's merged so can you rebase/squash the 2 last commits (changelog + revert) so we only keep jordi's and your commits?

piao-mdsol commented 6 years ago

@jfeltesse-mdsol squashed!