mdsol / dice_bag

DiceBag is a library of rake tasks for configuring web apps in the style of The Twelve-Factor App.
MIT License
19 stars 4 forks source link

Remove trailing space from generated yaml warning message #84

Closed piao-mdsol closed 6 years ago

piao-mdsol commented 6 years ago

Hi there 👋

Noticed a trailing space 👾 is left in the generated yaml warning message. 👇

screenshot 2018-08-01 14 31 16

So take the chance to chop it ✂️ 🙂

FYI @mdsol/team-10

piao-mdsol commented 6 years ago

Hmm, not sure about the CI failure, seems not related though 😕 https://travis-ci.org/mdsol/dice_bag/jobs/410648898

image

piao-mdsol commented 6 years ago

I see.. we're removing failing ruby 1.9.3 from the CI in https://github.com/mdsol/dice_bag/pull/83/files#diff-354f30a63fb0907d4ad57269548329e3L3

jfeltesse-mdsol commented 6 years ago

since the code has changed, even a TEENY update may be needed.

piao-mdsol commented 6 years ago

Bumped and updated 8917c4b 🆙 🎈 (Waiting for #83 to fix the CI, will rebase after that)

piao-mdsol commented 6 years ago

@mdsol/team-10 Rebased and now CI passed, please 🙏

jfeltesse-mdsol commented 6 years ago

wasn't this the PR where you'd update the changelog and do a TEENY bump?

piao-mdsol commented 6 years ago

@jfeltesse-mdsol sorry I got completely lost between switching branches 😓 🙇 🤦‍♂️