search

mdsol / hale

HALe specification draft
9 stars 3 forks source link

Added Hale tutorial, updated README #11

Closed sheavalentine-mdsol closed 10 years ago

sheavalentine-mdsol commented 10 years ago

Summary of Changes: Added a Tutorial

Cleaned json in spec Rewrote section on render Now supports "enctype" and "request_encoding" as two separate fields Changed "enctype" default Cleaned up text for "options"

sheavalentine-mdsol commented 10 years ago

@fosdev - Please review

sheavalentine-mdsol commented 10 years ago

@fosrias - Please Review

fosrias commented 10 years ago

@sheavalentine-mdsol Great stuff.

sheavalentine-mdsol commented 10 years ago

@fosrias - I think I addressed all the comments.

sheavalentine-mdsol commented 10 years ago

In other words Please Merge if you're satisfied.

fosrias commented 10 years ago

@sheavalentine-mdsol Only one substantive comment to address and then we can merge. Would be good to have @ChazzMaTazz do a copy edit as well after we merge this.

fosrias commented 10 years ago

@brutski @miwest929 LGTM. Please merge when you are satisfied.

ChazzMaTazz commented 10 years ago

Shall I copyedit with the new changes?

On Aug 21, 2014, at 5:45 PM, "Mark W. Foster" notifications@github.com wrote:

@brutski @miwest929 LGTM. Please merge when you are satisfied.

— Reply to this email directly or view it on GitHub.

miwest929 commented 10 years ago

@brutski Merge when satisfied.

sheavalentine-mdsol commented 10 years ago

Closes https://github.com/mdsol/hale/issues/8

sheavalentine-mdsol commented 10 years ago

@ChazzMaTazz - By all means copyedit a second time