Closed cmcinnes-mdsol closed 5 years ago
@mdsol/team-16 the file structure:
BEFORE REORG
AFTER REORG
Can you fix the
mauth-client-ruby/spec/signable_spec.rb:16: warning: already initialized constant Dummy::SIGNATURE_COMPONENTS_V2
mauth-client-ruby/spec/signable_spec.rb:16: warning: previous definition of SIGNATURE_COMPONENTS_V2 was here
warnings when running the specs?
Also wondering if mauth_client_spec.rb
should just be client_spec.rb
.
@ejennings-mdsol got rid of the warnings and renamed spec file to client_spec.rb
@mdsol/team-16
This PR breaks up the large
client.rb
file. No functional changes have been made. Opening as draft for now.So far I've moved
Authenticator
,LocalAuthenticator
,Signer
,RemoteAuthenticator
, and the error classes in to their own files. I also put thev2.rb
methods back in their respective modules and stopped the monkey patching in that file.