search

mdsol / mesos_cookbook

Chef cookbook for installing Apache Mesos
Other
78 stars 70 forks source link

Proxy for yum repository #122

Closed RedWhiteMiko closed 8 years ago

rveznaver commented 8 years ago

HI @RedWhiteMiko, thank you for you pull request. However, I think that for a feature to be merged it should be available for all supported platforms. In addition, it is not the best practice to configure only one option for a provider in an attribute, and leave the rest hard coded in the recipe. I think it may be best if you use a wrapper cookbook around this one, set default['mesos']['repo'] = false, and write the default recipe to be something like this:

include_recipe 'yum'

yum_repository 'mesosphere' do
  description 'Mesosphere Packages for Enteprise Linux'
  baseurl "http://repos.mesosphere.io/el/<my_version>/$basearch/"
  gpgkey 'https://repos.mesosphere.io/el/RPM-GPG-KEY-mesosphere'
  proxy <my_proxy>
end

include_recipe[mesos]
RedWhiteMiko commented 8 years ago

Hi @rveznaver, Thanks for the input, what if it's also added to apt_repository?