search

mdsol / mesos_cookbook

Chef cookbook for installing Apache Mesos
Other
78 stars 70 forks source link

Export shell variables #135

Closed cdegroot closed 7 years ago

cdegroot commented 8 years ago

This allows passing of settings like DOCKER_CONFIG through to spawned docker processes.

rveznaver commented 8 years ago

How is this different than using the --executor_environment_variables=VALUE option to pass ENV variables to the executor?

cdegroot commented 8 years ago

This is simpler? ;)

rveznaver commented 8 years ago

The only reason why we have those env variables in the first place is because of the ulimit.

Also, the difference between: default['mesos']['slave']['flags']['env']['DOCKER_CONFIG'] = 'whatever' and default['mesos']['slave']['flags']['executor_environment_variables'] = { 'DOCKER_CONFIG' => 'whatever' } is not that big :)

cdegroot commented 8 years ago

You got a point there. I wasn't aware of this option (the list is so long). Will give it a shot next week and then close this.