mdsol / rwslib

Provide a (programmer) friendly client library to Rave Web Services (RWS).
MIT License
30 stars 13 forks source link

Feature/modm support v1 #80

Closed glow-mdsol closed 7 years ago

glow-mdsol commented 7 years ago

@isparks @davecharles @rsayer-mdsol - for review, please don't merge yet. A massive replumbing of the builders; any comments muchly appreciated

mattkoch614 commented 7 years ago

Dumb question - what does "modm" support mean? I see quite a few new nodes that I haven't seen before in the ODM spec.

glow-mdsol commented 7 years ago

@mattkoch614 - these are some extensions we're adding for an operationalised batch type processing of external data. If any of them are worth adding, we'll propose them to the ODM group for consideration in ODM v2

isparks commented 7 years ago

Reviewed new changes for LocationOIDType. Do docs need updating for these changes?

glow-mdsol commented 7 years ago

Yes, they will. Updating.

Geoff

Geoff Low Ph.D. | Senior Lead Systems Architect | Medidata Solutions

Metro Building, 7th floor, 1 Butterwick, Hammersmith, London W6 8DL. glow@mdsol.com emailaddress@mdsol.com | direct: +44 (0) 208 6006504 | main: +44 (0)208 7410333

On 20 June 2017 at 18:15, Ian Sparks notifications@github.com wrote:

Reviewed new changes for LocationOIDType. Do docs need updating for these changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mdsol_rwslib_pull_80-23issuecomment-2D309810303&d=DwMCaQ&c=fi2D4-9xMzmjyjREwHYlAw&r=HO1-C4sM-nPhn5RwQjRknw&m=yHRIrIEj6WcNTayZxwdDVFLAiL7nchM8t8eS3L6ARZc&s=8BMgGe4n_-ffUsJ0wSNeLu9uzeGDT47WSyUIddFrL1o&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABEHyfaYm3-2DGOvDHAVwq8rDLr8DpJ7hCks5sF-5FAagaJpZM4NEzqz&d=DwMCaQ&c=fi2D4-9xMzmjyjREwHYlAw&r=HO1-C4sM-nPhn5RwQjRknw&m=yHRIrIEj6WcNTayZxwdDVFLAiL7nchM8t8eS3L6ARZc&s=kpLvIWX1FbsUuz0w-esOgSjMN0qtStUzBqlUkusof2o&e= .

iansparks commented 7 years ago

Review completed, no further comments.

iansparks commented 7 years ago

Reviewed SubjectUUID change. No comments.