mdsr-book / mdsr

Complement to CRC Press book *Modern Data Science with R*
39 stars 25 forks source link

possible issue with "etl_NCI60()" function on windows #30

Closed nicholasjhorton closed 6 years ago

nicholasjhorton commented 6 years ago

A user reported the following issue (under windows):

Here is the error again and session info

NCI60 <- etl_NCI60() trying URL 'https://github.com/beanumber/mdsr/blob/master/data-raw/NCI60.rda?raw=true' Content type 'application/octet-stream' length 5205412 bytes (5.0 MB) downloaded 5.0 MB

Error in load(lcl) : bad restore file magic number (file may be corrupted) -- no data loaded In addition: Warning messages: 1: In readChar(con, 5L, useBytes = TRUE) : invalid or incomplete compressed data 2: file ‘NCI60.rda’ has magic number '' Use of save versions prior to 2 is deprecated

sessionInfo() R version 3.4.4 (2018-03-15) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default

locale: [1] LC_COLLATE=English_United States.1252 LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] mosaic_1.1.1 Matrix_1.2-12 mosaicData_0.16.0 ggformula_0.6.2 lattice_0.20-35
[6] forcats_0.3.0 stringr_1.3.0 dplyr_0.7.4 purrr_0.2.4 readr_1.1.1
[11] tidyr_0.8.0 tibble_1.4.2 ggplot2_2.2.1 tidyverse_1.2.1 mdsr_0.1.5

loaded via a namespace (and not attached): [1] reshape2_1.4.3 splines_3.4.4 haven_1.1.1 colorspace_1.3-2 yaml_2.1.18
[6] rlang_0.2.0 pillar_1.2.1 foreign_0.8-69 glue_1.2.0 DBI_0.8
[11] dbplyr_1.2.1 readxl_1.0.0 modelr_0.1.1 bindrcpp_0.2.2 bindr_0.1.1
[16] plyr_1.8.4 mosaicCore_0.4.2 cellranger_1.1.0 munsell_0.4.3 gtable_0.2.0
[21] rvest_0.3.2 psych_1.8.3.3 parallel_3.4.4 babynames_0.3.0 broom_0.4.4
[26] Rcpp_0.12.16 scales_0.5.0 jsonlite_1.5 gridExtra_2.3 mnormt_1.5-5
[31] RMySQL_0.10.14 hms_0.4.2 digest_0.6.15 stringi_1.1.7 grid_3.4.4
[36] cli_1.0.0 tools_3.4.4 magrittr_1.5 lazyeval_0.2.1 ggdendro_0.1-20 [41] crayon_1.3.4 pkgconfig_2.0.1 MASS_7.3-49 xml2_1.2.0 downloader_0.4
[46] lubridate_1.7.2 rstudioapi_0.7 assertthat_0.2.0 httr_1.3.1 R6_2.2.2
[51] nlme_3.1-131.1 compiler_3.4.4

Is there an issue with this function running on windows? I've been unable to replicate it.

beanumber commented 6 years ago

@nicholasjhorton This works for me on Ubuntu. I haven't been able to confirm on Windows. Do you think this is still an issue?

nicholasjhorton commented 6 years ago

I just ran this successfully on MacOS X just this week. Unfortunately, I don't have access to a Windows box.

beanumber commented 6 years ago

Me either. It is safe to close this @nicholasjhorton ?

muschellij2 commented 3 years ago

For anyone who reaches here for some reason, this issue may also because of mode on download.file, so try with download.file(mode = "wb") if trying a binary file.