search

mdsr-book / mdsr

Complement to CRC Press book *Modern Data Science with R*
38 stars 25 forks source link

remove tidyverse from Imports #31

Closed beanumber closed 6 years ago

beanumber commented 6 years ago

As of 2018-03-30, your package, mdsr, lists the tidyverse package in either Depends, Imports, or Suggests on CRAN.

Because the tidyverse is a set of packages designed for interactive data analysis, this is, in short, a bad idea. The tidyverse package includes a substantial number of direct and indirect dependencies (79 packages, as of this writing), many of which are likely unnecessary for the purposes of your package. Furthermore, the CRAN maintainers frown upon depending on it, which can cause hassle for you down the line.

If you could please correct this by importing functions from, suggesting, or depending on the tidyverse component packages you require at your nearest convenience, it would be most appreciated.

Please let us know if you have any questions.

Thank you,

Hadley Wickham c/o Mara Averick

beanumber commented 6 years ago

The issue actually occurs here:

https://github.com/beanumber/mdsr/blob/acc652e6acd1025520b2a3da8a6858b55946cbb5/R/attach.R#L23

That is, we are actually importing a function from tidyverse.