mdsr-book / mdsr

Complement to CRC Press book *Modern Data Science with R*
39 stars 25 forks source link

Master table doesn't exist. #68

Closed gjm112 closed 11 months ago

gjm112 commented 11 months ago

Exercises in Section 5.5, Problem 2. In the Lahman database there is no table called Master. I believe it is called People.

nicholasjhorton commented 11 months ago

Thanks! I'm on it.

Here are the exercises I've found that use the deprecated table:

cheetah-sit-car.Rmd:TITLE GOES HERE: Use the `r df_macro(Batting)`, `r df_macro(Pitching)`, and `r df_macro(Master)` tables in the `r pkg_macro(Lahman)` package to answer the following questions.
cheetah-sit-car.Rmd:a. Name every player in baseball history who has accumulated at least 300 home runs (`r mdsr2exercises::var_macro(HR)`) and at least 300 stolen bases (`r mdsr2exercises::var_macro(SB)`). You can find the first and last name of the player in the `r df_macro(Master)` data frame. Join this to your result along with the total home runs and total bases stolen for each of these elite players.
cheetah-sit-car.Rmd:  left_join(Master, by = c("playerID" = "playerID")) %>%
cheetah-sit-car.Rmd:  left_join(Master, by = c("playerID" = "playerID")) %>%
cheetah-sit-car.Rmd:  left_join(Master, by = c("playerID" = "playerID")) %>%
pig-draw-bulb.Rmd:TITLE GOES HERE: The `Master` table of the `r pkg_macro(Lahman)` database contains biographical information about baseball players. The primary key is the `playerID` variable. There are also variables for `retroID` and `bbrefID`, which correspond to the player's identifier in other baseball databases. Discuss the ramifications of placing a primary, unique, or foreign key on `retroID`.
pig-draw-bulb.Rmd:glimpse(Master)
pine-tug-dish.Rmd:  inner_join(Master, by = c("playerID" = "playerID")) %>%
seaweed-cut-knob.Rmd:LEFT JOIN Master m ON b.playerid = m.playerid
seaweed-cut-knob.Rmd:LEFT JOIN Master m ON p.playerid = m.playerid
seaweed-cut-knob.Rmd:   JOIN Master m ON m.playerID = b.playerID
gjm112 commented 11 months ago

Thanks! Your book is amazing!!!

On Thu, Sep 28, 2023, 10:59 AM Nicholas Horton @.***> wrote:

Thanks! I'm on it.

Here are the exercises I've found that use the deprecated table:

cheetah-sit-car.Rmd:TITLE GOES HERE: Use the r df_macro(Batting), r df_macro(Pitching), and r df_macro(Master) tables in the r pkg_macro(Lahman) package to answer the following questions. cheetah-sit-car.Rmd:a. Name every player in baseball history who has accumulated at least 300 home runs (r mdsr2exercises::var_macro(HR)) and at least 300 stolen bases (r mdsr2exercises::var_macro(SB)). You can find the first and last name of the player in the r df_macro(Master) data frame. Join this to your result along with the total home runs and total bases stolen for each of these elite players. cheetah-sit-car.Rmd: left_join(Master, by = c("playerID" = "playerID")) %>% cheetah-sit-car.Rmd: left_join(Master, by = c("playerID" = "playerID")) %>% cheetah-sit-car.Rmd: left_join(Master, by = c("playerID" = "playerID")) %>% pig-draw-bulb.Rmd:TITLE GOES HERE: The Master table of the r pkg_macro(Lahman) database contains biographical information about baseball players. The primary key is the playerID variable. There are also variables for retroID and bbrefID, which correspond to the player's identifier in other baseball databases. Discuss the ramifications of placing a primary, unique, or foreign key on retroID. pig-draw-bulb.Rmd:glimpse(Master) pine-tug-dish.Rmd: inner_join(Master, by = c("playerID" = "playerID")) %>% seaweed-cut-knob.Rmd:LEFT JOIN Master m ON b.playerid = m.playerid seaweed-cut-knob.Rmd:LEFT JOIN Master m ON p.playerid = m.playerid seaweed-cut-knob.Rmd: JOIN Master m ON m.playerID = b.playerID

— Reply to this email directly, view it on GitHub https://github.com/mdsr-book/mdsr/issues/68#issuecomment-1739609566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZJJNRGFNSQ2OZPYHGPBTX4WNFPANCNFSM6AAAAAA5LBMNMU . You are receiving this because you authored the thread.Message ID: @.***>

beanumber commented 11 months ago

Fixed via https://github.com/mdsr-book/mdsr2exercises/commit/0c446097da127b5bd8fda5f4f9584a8696938685