search

mdsteele / rust-cab

Rust library for encoding/decoding Windows cabinet (.cab) files
MIT License
15 stars 8 forks source link

Feature/rewrite api #21

Closed ikrivosheev closed 1 year ago

ikrivosheev commented 1 year ago

Hello, thank you for the great library! The PR improves and makes API more ergonomic and fix problem with performance. Structure is: Cabinet -> FolderEntries -> FolderReader -> FileEntries -> FileReader.

Changes

  1. Replace actions-rs to dtolnay/rust-toolchain because actions-rs is deprecated
  2. Added FolderReader for iterate over FileReader
  3. Added FileReader for reader file from cab

Breaking changes

  1. Removed Cabinet::get_file_entry
  2. Removed Cabinet::read_file

If the idea is ok I can finish it.

This is continue of: https://github.com/mdsteele/rust-cab/pull/20

ikrivosheev commented 1 year ago

Sorry, finally found time to look at this again. Thanks for your patience!

Just to check: is this PR still in progress, or is it ready to go? (I think you mentioned in an earlier comment that you wanted to add Cabinet::read_file.)

Hello! Yes, you are right) I am working on add Cabinet::read_file. I think, I can do this.