fix: Truncated fat entries on error

mdsteele / rust-cfb

Rust library for reading/writing Compound File Binary (structured storage) files

MIT License

44 stars 20 forks source link

fix: Truncated fat entries on error #44

Open ikrivosheev opened 1 year ago

ikrivosheev commented 1 year ago

Closed: https://github.com/mdsteele/rust-cfb/issues/41

mdsteele commented 1 year ago

Looks like this needs some test updates.

ikrivosheev commented 2 months ago

@ideeockus thank you for the help! @mdsteele could you review?)

mdsteele commented 2 months ago

Thanks, and sorry for the slow replies on my part. Could we add a unit test for this? It would be good to have. Also, I guess I'm concerned that this might not be the best way to solve the problem (I'm worried it will cover up other kinds of errors that it shouldn't), but having something to test against will make it easier to try out alternative solutions in the future.