Add support for the decoding of jpeg2000

mdsteele / rust-icns

Rust library for encoding/decoding Apple Icon Image (.icns) files

MIT License

24 stars 10 forks source link

Add support for the decoding of jpeg2000 #7

Open CharlieS1103 opened 1 year ago

CharlieS1103 commented 1 year ago

Note: I'm not that experienced in rust (this is essentially my first real project in the language) so let me know if I did anything wrong. Also, I believe that the test case is in the jp2000, however, it is different than all the other test cases, I simply have no idea how to create my own .icns file containing a jp2k checkmark.

0rvar commented 6 months ago

Any way I can help land this PR?

CharlieS1103 commented 6 months ago

@0rvar For sure, I think everything i've added so far has some major conceptual errors, and I'd still like to get this running smoothly so my current project can function without hiccups, if you have any ideas please feel free to throw them in!

0rvar commented 6 months ago

I've gotten jpeg2000 support working for my own test cases in my own fork, I have opened a chained PR to this branch in the fork:

https://github.com/CharlieS1103/rust-icns/pull/1