search

mdsteele / rust-msi

Rust library for reading/writing Windows Installer (MSI) files
MIT License
58 stars 11 forks source link

The encoding crate is unmaintained #14

Closed messense closed 1 year ago

messense commented 1 year ago

https://github.com/rustsec/advisory-db/issues/1605

Is it possible to migrate to encoding_rs?

ikrivosheev commented 1 year ago

@messense the biggest problem to migrate to encoding_rs is it doesn't support ASCII encoding.

mdsteele commented 1 year ago

Seems like it shouldn't be too hard to emulate the ASCII encoding behavior of the old encoding crate by hand (which I believe just replaces any non-ASCII characters with '?' when encoding; see this rust-msi unit test).

If anyone wants to take a shot at this, a PR would be very welcome.

messense commented 1 year ago

I took a naive shot in https://github.com/mdsteele/rust-msi/pull/15, please take a look, thanks!