search

mdsteele / rust-msi

Rust library for reading/writing Windows Installer (MSI) files
MIT License
58 stars 11 forks source link

Ignore unknown `Category` instead of returning an error #29

Closed shamilsan closed 3 months ago

shamilsan commented 3 months ago

I encountered a problem when trying to open one MSI package with undocumented “Number” category. In my opinion, it is better to ignore unknown categories rather than to return an error.

shamilsan commented 3 months ago

Dear @mdsteele,

What do you think about it?

mdsteele commented 3 months ago

Seems reasonable, sorry for the slow reply. Looks like there were some clippy errors unrelated to your change; if you rebase those should be fixed now, and then we can merge.

shamilsan commented 3 months ago

@mdsteele,

Thanks for your reply. I've synced my fork with the upstream, could you please try again?

mdsteele commented 3 months ago

Merged, thanks!