search

mdsumner / spdplyr

Data Manipulation Verbs for Spatial Classes
http://mdsumner.github.io/spdplyr/
42 stars 5 forks source link

need fix for new distinct .keep_all behaviour #3

Closed mdsumner closed 7 years ago

mdsumner commented 8 years ago

distinct(sp, what, ever, .keep_all = TRUE) is fine but other wise not

mdsumner commented 8 years ago

not released yet https://github.com/hadley/dplyr/blob/master/NEWS.md

mdsumner commented 8 years ago

probably can make this the default in the methods? What about overrides? Convert to tibble, dropping geometry?

mdsumner commented 7 years ago

I think we are ok here. I have put in a warning if .keep_all = TRUE, it's up to the user (and I don't think anyone would use this).