search

mduran80 / daikin_madoka

Home Assistant custom component integration for the BRC1H thermostat (madoka)
MIT License
52 stars 15 forks source link

Upcoming changes: HA CORE 2025.1 new climate constants #41

Open 0000vt opened 7 months ago

0000vt commented 7 months ago

Logger: homeassistant.components.climate.const Bron: helpers/deprecation.py:205 integratie: Klimaat (documentation, issues) First occurred: 17:05:49 (13 gebeurtenissen) Laatst gelogd: 17:05:49

HVAC_MODE_FAN_ONLY was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.FAN_ONLY instead, please report it to the author of the 'daikin_madoka' custom integration HVAC_MODE_HEAT was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please report it to the author of the 'daikin_madoka' custom integration HVAC_MODE_OFF was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'daikin_madoka' custom integration SUPPORT_FAN_MODE was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.FAN_MODE instead, please report it to the author of the 'daikin_madoka' custom integration SUPPORT_TARGET_TEMPERATURE was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'daikin_madoka' custom integration

BeFygo commented 4 months ago

The LOG changed after the update to sensor.py; climate.py; init.py last month.

Logger: homeassistant.components.climate Source: components/climate/init.py:371 integration: Climate (documentation, issues) First occurred: 20:18:48 (3 occurrences) Last logged: 20:18:48

Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'daikin_madoka' custom integration Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'daikin_madoka' custom integration Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) implements HVACMode(s): fan_only, dry, cool, heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'daikin_madoka' custom integration

mduran80 commented 4 months ago

Thank you, I will update the component (again).

El El lun, 10 jun 2024 a las 20:27, BeFygo @.***> escribió:

The LOG changed after the update to sensor.py; climate.py; init.py last month.

Logger: homeassistant.components.climate Source: components/climate/init.py:371 integration: Climate (documentation, issues) First occurred: 20:18:48 (3 occurrences) Last logged: 20:18:48

Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'daikin_madoka' custom integration Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'daikin_madoka' custom integration Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) implements HVACMode(s): fan_only, dry, cool, heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'daikin_madoka' custom integration

— Reply to this email directly, view it on GitHub https://github.com/mduran80/daikin_madoka/issues/41#issuecomment-2159026464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFK3CT5MQXT6DZYD777HLATZGXVYHAVCNFSM6AAAAABFF2C5HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGAZDMNBWGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

unaiherran commented 3 months ago

Hi,

It seems that the update 2025.1 will change many things to how HVAC are controlled.

This are a few warnings I have on my logs:

Logger: homeassistant.components.climate
Source: components/climate/__init__.py:365
integration: Climate ([documentation](https://www.home-assistant.io/integrations/climate), [issues](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+climate%22))
First occurred: 16:04:48 (3 occurrences)
Last logged: 16:04:48

Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'daikin_madoka' custom integration
Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'daikin_madoka' custom integration
Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) implements HVACMode(s): fan_only, dry, cool, heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'daikin_madoka' custom integration

Entity None (<class 'custom_components.daikin_madoka.climate.DaikinMadokaClimate'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <ClimateEntityFeature.TARGET_TEMPERATURE|FAN_MODE: 9>, please report it to the author of the 'daikin_madoka' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

TEMP_CELSIUS was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please report it to the author of the 'daikin_madoka' custom integration

HVAC_MODE_FAN_ONLY was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.FAN_ONLY instead, please report it to the author of the 'daikin_madoka' custom integration
HVAC_MODE_HEAT was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please report it to the author of the 'daikin_madoka' custom integration
HVAC_MODE_OFF was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'daikin_madoka' custom integration
SUPPORT_FAN_MODE was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.FAN_MODE instead, please report it to the author of the 'daikin_madoka' custom integration
SUPPORT_TARGET_TEMPERATURE was used from daikin_madoka, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'daikin_madoka' custom integration

I will try to make a pull request with these changes (if life let me do it)

amnsharif commented 3 weeks ago

I made a pull request for climate.py & init.py to accommodate the upcoming changes in HA 2025.1. Tested them on my HA instance and no more warning logs appear. Feel free to merge them @mduran80