search

mduran80 / pymadoka

A python library to control Daikin BRC1H (Madoka) thermostat
MIT License
26 stars 8 forks source link

Power State and Fan Speed use same topic #5

Open franzmueller opened 2 years ago

franzmueller commented 2 years ago

Hi there, I noticed in mqtt.py the constants POWER_STATE_TOPIC and FAN_SPEED_TOPIC are using the same topic "fan_speed": https://github.com/mduran80/pymadoka/blob/412daaffa77d5330b25c9d38e8e65fa441bd1ce8/pymadoka/mqtt.py#L185

Therefore the comparison in on_message line 333 will never be True: https://github.com/mduran80/pymadoka/blob/412daaffa77d5330b25c9d38e8e65fa441bd1ce8/pymadoka/mqtt.py#L333

I'm assuming the POWER_STATE_TOPIC constant should be different?

Thanks for providing the well-documented library :)