search

mduran80 / pymadoka

A python library to control Daikin BRC1H (Madoka) thermostat
MIT License
26 stars 8 forks source link

pymadoka-mqtt mqtt.py (set_power_state) can not set "on" #9

Closed oyola0 closed 1 year ago

oyola0 commented 1 year ago

In the following line: https://github.com/mduran80/pymadoka/blob/main/pymadoka/mqtt.py#L129 payload always returns (b + message) like: b'on' The error is: status = PowerStateStatus(payload=="on") however should be: status = PowerStateStatus(payload.decode("utf-8")=="on")

oyola0 commented 1 year ago

I think that the following line has the same error: https://github.com/mduran80/pymadoka/blob/main/pymadoka/mqtt.py#L148 But i don't check it yet

mduran80 commented 1 year ago

Hi!

Yo are right in both cases, I will fix it and update the release. Thanks!!

El El mié, 26 oct 2022 a las 13:25, oyola @.***> escribió:

I think that the following line has the same error: https://github.com/mduran80/pymadoka/blob/main/pymadoka/mqtt.py#L148 But i don't check it yet

— Reply to this email directly, view it on GitHub https://github.com/mduran80/pymadoka/issues/9#issuecomment-1291885203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFK3CT6X5CIXQVXMKFM3EWDWFEIKDANCNFSM6AAAAAARO4HPME . You are receiving this because you are subscribed to this thread.Message ID: @.***>