search

mduvall / grande.js

It's a Medium at Starbucks. Pinky ring out.
MIT License
1.3k stars 80 forks source link

Options init problem #45

Closed netoneko closed 11 years ago

netoneko commented 11 years ago

Please take a look at this commit: https://github.com/netoneko/grande.js/commit/93156c0f65453aa0d921390b51496121e65c538b

You set options after init has already happened which makes them essentially useless.

mduvall commented 11 years ago

Great catch, if you want you could make a pull request if you want to get the commit in - if not I'll add it and reference your change.

Thanks for that @netoneko!

mduvall commented 11 years ago

Closed via https://github.com/mduvall/grande.js/pull/46.