Add rounded corners - Githubissues

mdwheele / owls

🦉 Easy management of /etc/hosts built on top of Electron.

MIT License

3 stars 0 forks source link

Add rounded corners #25

Closed rmeby closed 2 months ago

rmeby commented 4 years ago

Work in progress. Attempting to address #9. Stole some ideas from https://github.com/mdwheele/owls/pull/11/commits/3e82e9df7eb53aa9ef35c564be07f883dbf8df93

This looks absolutely disgusting on Ubuntu 20.04 but quite nice on Windows 10.

Gander.setGood(!Goose.isGood(this))

rmeby commented 4 years ago

@mdwheele This is looking pretty good to me. I was able to test on Windows 10 and Xubuntu 18.04. Not able to test on macOS at the moment, but can do that later if desired. When you have time, please take a look!

Windows 10

owls-windows-10

Xubuntu 18.04

owls-xubuntu-18 04

rmeby commented 4 years ago

macOS 10.15.7

mdwheele commented 4 years ago

Oh man, so much rounded. It's amazing. This looks great to me.

Does the MacOS shadow look much darker? I bet they're putting a shadow on the native window so that when we add our own, it doubles up. Could you see how disabling shadow on BrowserWindow affects things? We're never going to get pixel-perfect likeness everywhere, but worth a shot to get close.

rmeby commented 4 years ago

Sure! Here it is with hasShadow: false on macOS. Looks like the others now. I will commit this.

rmeby commented 4 years ago

@mdwheele Just noting this is ready for review whenever you have time. Thanks!