search

mdwiltfong / reactive-weather-app

https://reactive-weatherapp.herokuapp.com/
0 stars 0 forks source link

DateFormatter class doesn't correctly show minutes less than 10. #35

Closed mdwiltfong closed 1 year ago

mdwiltfong commented 1 year ago

At the moment the DateFormatter object won't return the following time 1:05 am Instead, it will return 1:5 am . this is because the .getMinutes() function on the date object returns a number from 0 to 59.

IlmaMuttaqien commented 1 year ago

Please check my PR for this Issue

mdwiltfong commented 1 year ago

Hey @IlmaMuttaqien ! Thank you so much for doing this PR. Looking at the code it should definitely work! Any chance you'd be interested in modifying the tests as well :)

IlmaMuttaqien commented 1 year ago

i've modify the test and update my PR to #37

mdwiltfong commented 1 year ago

image

You're the best @IlmaMuttaqien ! Thanks for taking the time to help with this ❤️