search

mdwiltfong / secret-santa

https://codecademy-secret-santa-2.fly.dev/
3 stars 6 forks source link

Axios Instance #48

Open mdwiltfong opened 10 months ago

mdwiltfong commented 10 months ago

In order to consolidate the HTTP requests the front end will make, the repo will need a single class or function that will make HTTP requests.

MelindaH26 commented 10 months ago

Thanks for setting up the issue @mdwiltfong. Could you please assign me?

mdwiltfong commented 10 months ago

Hey @MelindaH26 !

Let me get a PR out there to knock out the TypeScript for this issue first!

MelindaH26 commented 10 months ago

Thanks @mdwiltfong , sounds good!

In the meantime I will learn some more about Axios and writing tests. I think the back-end course mostly teaches Mocha ... hopefully that will still come in handy.

mdwiltfong commented 9 months ago

@MelindaH26 ,

I just merged PR #52 , which adds the axios dependency and some boiler plate code

mdwiltfong commented 7 months ago

Hey @MelindaH26 !

Sorry I've been on vacation for a couple weeks. Are you still interested in working on this?

MelindaH26 commented 7 months ago

Hi @mdwiltfong,

No worries, I hadn't worked on it because I wasn't sure if the project was still going ahead.

I'm hoping I will have the time for it - I just got a new job so I will see if I can work on it before the next meetup. If not, maybe we will have to pass it on to someone else because I don't want to be holding everyone up.

mdwiltfong commented 7 months ago

Hey! Wow congratulations on the new job @MelindaH26 ! No worries, let's talk about in the next meetup!