search

mdx-editor / editor

A rich text editor React component for markdown
https://mdxeditor.dev
MIT License
1.97k stars 148 forks source link

Plugin toolbar add height limit for select element #343

Closed newproplus closed 9 months ago

newproplus commented 9 months ago

This is very userful for mobile devices, especially when the code block has many languages.

petyosi commented 9 months ago

The purpose of this PR makes a lot of sense, but I do want to push such styling configuration into css variables. In this case, a --toolbar-select-max-height on the root level would drastically simplify the implementation and will keep it consistent with the rest of the visual configs (fonts, colors, etc). It's also easier to control with media queries.

Let me know what you think.

newproplus commented 9 months ago

I think both CSS and JavaScript can be used, the only difference may be that JavaScript has less code.

github-actions[bot] commented 9 months ago

:tada: This issue has been resolved in version 2.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

petyosi commented 9 months ago

I added a public CSS class that lets you safely target that element through a selector. This has multiple benefits, including media queries, additional properties, etc.