search

mdx-editor / editor

A rich text editor React component for markdown
https://mdxeditor.dev
MIT License
1.63k stars 131 forks source link

feat: Add aria-label to MDXEditor and SingleChoiceToggleGroup #460

Closed dharanish-v closed 2 months ago

dharanish-v commented 2 months ago

The code changes add aria-label attributes to the MDXEditor and SingleChoiceToggleGroup components to improve accessibility.

closes #459

petyosi commented 2 months ago

Question - should those values be translated as well?

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dharanish-v commented 2 months ago

Question - should those values be translated as well?

Yes, it would be better if someone using a screen reader in another language would like to hear in their language. Sorry that i Missed translations in the PR.

petyosi commented 2 months ago

Feel free to add another PR with the translations when you have the time. My guess is that it's better to have this merged rather than not.