search

mdx-editor / editor

A rich text editor React component for markdown
https://mdxeditor.dev
MIT License
1.57k stars 124 forks source link

feat: Add aria-label to CreateLink button #492

Closed dharanish-v closed 3 weeks ago

dharanish-v commented 4 weeks ago

Added aria-label to improve accessibility

closes #493

petyosi commented 3 weeks ago

This should use the translation I believe?

dharanish-v commented 3 weeks ago

This should use the translation I believe?

I have few more changes to this PR, I will push those in an hour

dharanish-v commented 3 weeks ago

This should use the translation I believe?

I have few more changes to this PR, I will push those in an hour

done

dharanish-v commented 3 weeks ago

This should use the translation I believe?

can we merge this by today ?

petyosi commented 3 weeks ago

No. It fails the prettier check. I will add the change as a part of a larger commit.

dharanish-v commented 3 weeks ago

No. It fails the prettier check. I will add the change as a part of a larger commit.

I have made the changes, now it won't fail, kindly check because i need this for a task as soon as possible.

github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 3.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: