mdx-js / eslint-mdx

ESLint Parser/Plugin for MDX

https://npmjs.org/eslint-plugin-mdx

MIT License

264 stars 32 forks source link

fix: only apply fix once for the whole file #309

Closed JounQin closed 3 years ago

JounQin commented 3 years ago

close #308

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov-commenter commented 3 years ago

Codecov Report

Merging #309 (6c93079) into master (94a08af) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          466       470    +4     
  Branches        94        96    +2     
=========================================
+ Hits           466       470    +4

Impacted Files	Coverage Δ
packages/eslint-plugin-mdx/src/rules/remark.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94a08af...6c93079. Read the comment docs.

JounQin commented 3 years ago

@wooorm Please help to review and release for recent updates.

JounQin commented 3 years ago

@wooorm No worry, we have a lot of test cases to ensure it's just working.

wooorm commented 3 years ago

:+1:

I’m waiting for this to be merged, and will cut a new release then, okay?

JounQin commented 3 years ago

@wooorm Let's go ahead!

wooorm commented 3 years ago

Bunch of tests are failing for me when I clone, install, and yarn test locally?

wooorm commented 3 years ago

Hmm. yarn build first I think solved it?

wooorm commented 3 years ago

Released!

JounQin commented 3 years ago

Hmm. yarn build first I think solved it?

Good to hear, but it seems wired, I'll try to find out and fix this problem soon.

wooorm commented 3 years ago

note: I did yarn and then yarn test (under the assumption that test would first build and such). Maybe that assumption is just wrong!

JounQin commented 3 years ago

yarn test should work without build, because we are using ts-jest.

I've just found it should be related to paths of tsconfig.

Missing baseUrl in compilerOptions. tsconfig-paths will be skipped